TransactionTemplate leaks transactions when TransactionCallback propagates undeclared checked exception [SPR-6361]

[spring-projects-issues]

Marat Radchenko opened SPR-6361 and commented

TransactionTemplate doesn't neither commit nor rollback on checked exception, causing leakage.

See attached testcase.

---

Affects: 2.5.6

Attachments:

• CheckedExceptionTest.java (2.61 kB)

Issue Links:

• Clarify rollback-on consistency between DefaultTransactionAttribute and TransactionTemplate [SPR-14994] #19560 Clarify rollback-on consistency between DefaultTransactionAttribute and TransactionTemplate
• Remove unreachable code from TransactionTemplate [SPR-10148] #14781 Remove unreachable code from TransactionTemplate

Referenced from: commits a741410

[spring-projects-issues]

Juergen Hoeller commented

Fixed through catching Exception now. Note that a checked exception will be converted into an UndeclaredThrowableException since we technically can't rethrow an undeclared checked exception ourselves. (Frankly, it's quite odd that Java allows for it from reflectively called constructors.)

Juergen

[spring-projects-issues]

Marat Radchenko commented

Actually you can rethrow it, using the same technic i used to throw it in first place.