AnnotationUtils provides poor diagnostics if getDeclaredAnnotations throws an exception [SPR-12325]

[spring-projects-issues]

Andy Wilkinson opened SPR-12325 and commented

This is a follow-on from #16493, triggered by this bug report against Spring Boot.

PR showing how this could be further improved to follow.

---

Affects: 4.0.7, 4.1.1

Issue Links:

• AnnotationUtils.findAnnotation fails with poor diagnostics if it encounters an Annotation that references an unloadable class [SPR-11874] #16493 AnnotationUtils.findAnnotation fails with poor diagnostics if it encounters an Annotation that references an unloadable class
• Regression: Commons Logging setup in AnnotationUtils causes early initialization of logging system [SPR-12329] #16934 Regression: Commons Logging setup in AnnotationUtils causes early initialization of logging system
• Favor more locally declared composed annotations over interface annotations in AnnotationUtils [SPR-12355] #16960 Favor more locally declared composed annotations over interface annotations in AnnotationUtils
• Defensive error reporting when ConfigurationClassParser introspects declared methods via StandardAnnotationMetadata [SPR-13791] #18364 Defensive error reporting when ConfigurationClassParser introspects declared methods via StandardAnnotationMetadata
• Improve diagnostics when OrderUtils.getPriority encounters an ArrayStoreException during annotation introspection [SPR-12357] #16962 Improve diagnostics when OrderUtils.getPriority encounters an ArrayStoreException during annotation introspection
• Improve diagnostics when AnnotationAttributesReadingVisitor triggers an ArrayStoreException from Class.getAnnotations() [SPR-12387] #16995 Improve diagnostics when AnnotationAttributesReadingVisitor triggers an ArrayStoreException from Class.getAnnotations()
• AnnotatedElementUtils should leniently ignore TypeNotPresentExceptions (just like AnnotationUtils) [SPR-12889] #17487 AnnotatedElementUtils should leniently ignore TypeNotPresentExceptions (just like AnnotationUtils)

Referenced from: commits e16f21c, 47dde91, 716916b

Backported to: 4.0.8

[spring-projects-issues]

Andy Wilkinson commented

Hi, Juergen. Here's a pull request for the change that I think needs to be made: #660. It makes exception handling for calls to getDeclaredAnnotations consistent within AnnotationUtils.

[spring-projects-issues]

Andy Wilkinson commented

For the scenario described in this Boot issue the changed made in this commit has made the diagnostics worse as things now fail silently. This catch block that returns null without logging is the culprit. Could it be updated to also call logIntrospectionFailure?

[spring-projects-issues]

Juergen Hoeller commented

Oops, that was a plain oversight after refactoring. To be pushed along with the fix for #16962.

Juergen