Update AnnotationUtils to always call getDeclaredAnnotations defensively #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, any exception thrown by getDeclaredAnnotations was not handled. Due to the JDKs pure diagnostics, this made problem diagnosis difficult as the details of the class that was being introspected were lost. This commit updates AnnotationUtils to always call getDeclaredAnnotations within a try-catch block. Any exception that is thrown is logged along with details of the class that was being introspected. Processing then continues as if no annotations were present. Issue: SPR-12325
|
Closing this one as the related issue has been fixed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any exception thrown by getDeclaredAnnotations was not
handled. Due to the JDKs pure diagnostics, this made problem diagnosis
difficult as the details of the class that was being introspected were
lost.
This commit updates AnnotationUtils to always call
getDeclaredAnnotations within a try-catch block. Any exception that is
thrown is logged along with details of the class that was being
introspected. Processing then continues as if no annotations were
present.
Issue: SPR-12325