Allow overriding InvocableHandlerMethod.invoke and/or ServletInvocableHandlerMethod.invokeAndHandle in subclasses [SPR-12484]

[spring-projects-issues]

Fabio Tudone opened SPR-12484 and commented

I'm writing a new HandlerMethod dispatching transparently (asynchronously) on lightweight threads and I could reuse most of the existing ServletInvocableHandlerMethod and InvocableHandlerMethod, except invoke is private in the latter and can't be overridden, and invokeAndHandle is final in the first one (and so still can't be overridden).

Would it be possible to ease these restrictions so as to make it easier to reuse existing implementations?

---

Affects: 4.0.8, 4.1.2

Reference URL: https://github.com/spring-projects/spring-framework/blob/v4.1.2.RELEASE/spring-web/src/main/java/org/springframework/web/method/support/InvocableHandlerMethod.java#L212

Issue Links:

• Making it easier to replace "RequestMappingHandlerAdapter.handleInternal" [SPR-12460] #17065 Making it easier to replace "RequestMappingHandlerAdapter.handleInternal"

Referenced from: commits 2496d68, 90ae073

Backported to: 4.0.9

[spring-projects-issues]

Juergen Hoeller commented

I've turned the private invoke methods to protected doInvoke methods, and removed the final modifiers from the public invokeAndHandle / invokeForRequest entry point methods in both classes, as well as in the analogous spring-messaging variant of InvocableHandlerMethod.

Juergen

[spring-projects-issues]

Fabio Tudone commented

Thanks so much! This will allow me to avoid copy&paste horrors (and associated maintenance nightmares).