EncodedResource does not include charset in equals() implementation [SPR-12767]

[spring-projects-issues]

Sam Brannen opened SPR-12767 and commented

Status Quo

EncodedResource supports an encoding or a Charset for reading from the underlying Resource; however, the implementation of equals() is based solely on the resource and encoding. Thus, if a Charset is specified instead of an encoding, invocations of equals() will not work as expected.

Deliverables

1. Include the Charset in the implementation of equals() in EncodedResource.

---

Affects: 3.2.1

Referenced from: commits 93c70b7, 1f9bc50, 6c93745

Backported to: 3.2.14

[spring-projects-issues]

Sam Brannen commented

Fixed as described in GitHub commits for Spring Framework releases 4.2, 4.1.6, and 3.2.14.

Include charset in EncodedResource.equals()

Prior to this commit, the implementation of equals() in EncodedResource
was based solely on the resource and encoding. Thus, if a Charset were
specified instead of an encoding, invocations of equals() would not
work as expected.

This commit addresses this issue by including the charset in the
implementation of equals() and introducing corresponding tests in a new
EncodedResourceTests class. Furthermore, this commit makes
EncodedResource immutable and updates all Javadoc to reflect support
for the encoding and charset properties.