CronSequenceGenerator constructor goes into infinite loop with invalid increments [SPR-12871]

[spring-projects-issues]

Edward opened SPR-12871 and commented

The constructor for the org.springframework.scheduling.support.CronSequenceGenerator will go into an infinite loop if one of the fields is of the form n/0

For example

public static void main (String[] s) {
    new CronSequenceGenerator("*/0 * * * * *");
    System.out.println("We will never get here");
}

I guess that either the /0 should be ignored, or it should throw an IllegalArgumentException

---

Affects: 3.2.13, 4.1.6

Issue Links:

• CronSequenceGenerator.next() is not implemented as documented [SPR-14589] #19158 CronSequenceGenerator.next() is not implemented as documented
• CronSequenceGenerator causes StackOverflowError with reversed range values [SPR-14462] #19031 CronSequenceGenerator causes StackOverflowError with reversed range values

Referenced from: commits ceb17fc, b5a56ca, 50f4977

Backported to: 3.2.14

[spring-projects-issues]

Juergen Hoeller commented

Good catch. We're explicitly checking the incrementer delta to be 1 or higher now, raising a descriptive IllegalArgumentException if invalid. (Negative deltas led to a non-descriptive IndexOutOfBoundsException before.)

Juergen

[spring-projects-issues]

Edward commented

Awesome - impressive turnaround!

Best regards
Ed