Nested arrays of annotations are synthesized with wrong component type [SPR-13077]

[spring-projects-issues]

Sam Brannen opened SPR-13077 and commented

Status Quo

The support for synthesizing annotations that was introduced in #16137 and #16138 incorrectly adapts a nested array of annotations by converting it to an array of generic annotations (i.e., Annotation[]). This improper behavior can lead to unexpected exceptions at run time -- for example, Annotation[] is not compatible with Filter[].

The broken code resides in AnnotationUtils.adaptValue().

Deliverables

1. Ensure that nested arrays of synthesized annotations are created with the appropriate component type.

---

Affects: 4.2 RC1

Referenced from: commits f41de12

[spring-projects-issues]

Sam Brannen commented

Fixed as described in GitHub commit f41de12:

Ensure synthesized nested annotation arrays retain correct type

Prior to this commit, when a nested array of annotations was synthesized while adapting values within an AnnotationAttributes map, the array was improperly replaced with an array of type Annotation[] instead of an array of the concrete annotation type, which can lead to unexpected run-time exceptions.

This commit fixes this bug by replacing annotations in the existing array with synthesized versions of those annotations, thereby retaining the original array's component type.