Improve DispatcherServlet diagrams [SPR-13120]

[spring-projects-issues]

Jesus Calimlim Angeles Jr. opened SPR-13120 and commented

The Figure in "Figure 17.2. Context hierarchy in Spring Web MVC" can be improved.

1. What is the significance of the blue two-headed arrows? Does it mean anything?
2. Why is the "WebApplicationContext(s)" having an "(s)"? It is the root application context if I am not wrong. There is only 1 if I am not wrong.
3. Why is the box of "WebApplicationContext(s)" showing multiple boxes? Does it represent multiple XML files forming one context? If so, it is not important to put it so, as any context is understood to possibly come from multiple XML files (or java config, etc.).

---

Affects: 4.1.6

Reference URL: http://docs.spring.io/spring-framework/docs/4.1.6.RELEASE/spring-framework-reference/html/images/mvc-contexts.gif

Referenced from: commits df9290c

0 votes, 5 watchers

[spring-projects-issues]

Rossen Stoyanchev commented

The blue arrows look like they represent the steps including invocation and what's being returned from each participant. As for the multiple "root" WebApplicationContexts, I believe in most cases it should be one context but there are some cases with EAR deployment where there can be a parent of the root context. Assuming I am correct we should simplify the diagram a bit.

[spring-projects-issues]

Sébastien Deleuze commented

I have simplified the diagram and added another one for the "single root context" use case.

[spring-projects-issues]

Brian Clozel commented

Much better!

[spring-projects-issues]

Jesus Calimlim Angeles Jr. commented

Looks great!