Skip to content

Ineffective synchronization in StandardTypeConverter constructor [SPR-14465] #19034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Jul 14, 2016 · 0 comments
Closed

Ineffective synchronization in StandardTypeConverter constructor [SPR-14465] #19034

spring-projects-issues opened this issue Jul 14, 2016 · 0 comments
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
4.3.2

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jul 14, 2016 •
edited
Loading

Juergen Hoeller opened SPR-14465 and commented

StandardTypeConverter's default constructor uses synchronized (this) for initializing a shared static DefaultConversionService. However, in a constructor, synchronization on this is effectively a no-op. Let's rather simply use a volatile variable there.

Affects: 3.2.17, 4.2.7, 4.3.1

Issue Links:

Referenced from: commits 0065a16, 97d73eb, 6d91d54, cb64dd1

Backported to: 4.2.8, 3.2.18
@spring-projects-issues spring-projects-issues added type: bug A general bug status: backported An issue that has been backported to maintenance branches in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.3.2 milestone Jan 11, 2019
This was referenced Jan 11, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
4.3.2
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues