TypeConverterSupport does not propagate custom exceptions anymore [SPR-14661]

[spring-projects-issues]

Valentin Tsvetkov opened SPR-14661 and commented

catch (Throwable ex) on line 77 in TypeConverterSupport. In SpringBoot application we can't properly use @ControllerAdvice because our specific exception that we throw in converter catches in TypeConverterSupport and instead it throws TypeMismatchException.

---

Affects: 4.2.7

Issue Links:

• Different error codes on same formatter registered in different ways [SPR-14345] #18917 Different error codes on same formatter registered in different ways
• HibernateExceptionTranslator translating to InvalidDataAccessApiUsageException when using vanilla Hibernate [SPR-14681] #19245 HibernateExceptionTranslator translating to InvalidDataAccessApiUsageException when using vanilla Hibernate

Referenced from: commits c69e6a3, 73bbe08, 883c3a6

Backported to: 4.2.8

[spring-projects-issues]

Juergen Hoeller commented

This seems to be a consequence of the fix in #18917 and therefore a regression. We'll revisit this for 4.2.8 / 4.3.3, possibly enumerating all actual type-mismatch-like exceptions there.

[spring-projects-issues]

Juergen Hoeller commented

I've revised the fix for #18917 such that it only applies to Formatter.parse invocations, not to general conversion attempts. Specifically, TypeConverterSupport just catches IllegalArgumentException again but FormatterPropertyEditorAdapter turns any exception into an IllegalArgumentException if necessary now.

[spring-projects-issues]

Juergen Hoeller commented

It would be great if you could give the latest 4.2.8.BUILD-SNAPSHOT or 4.3.3.BUILD-SNAPSHOT a try to check whether it works for you again...