Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support missing properties from Content-Disposition spec [SPR-15555] #20114

Closed
spring-projects-issues opened this issue May 16, 2017 · 2 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented May 16, 2017

Damiano Albani opened SPR-15555 and commented

The ContentDisposition implementation currently misses 3 properties which are described in the RFC2183 specification:

  1. creation-date
  2. modification-date
  3. read-date

As in:

disposition-parm := filename-parm
                  / creation-date-parm
                  / modification-date-parm
                  / read-date-parm
                  / size-parm
                  / parameter

It would nice to have support for those parameters in Spring Web.


Affects: 5.0 RC1

Reference URL: #1443

Issue Links:

Referenced from: commits 97909f2

@spring-projects-issues
Copy link
Collaborator Author

Sébastien Deleuze commented

Juergen Hoeller As discussed with Rossen Stoyanchev, before merging this PR we should choose a strategy regarding to date/time that we previously exposed with long like in HttpHeaders.getAccessControlMaxAge().

  • Should we continue to use long for consistency?
  • Should we add Instant based variants and maybe deprecate long based ones?

Given the fact that date/time can be confusing for the users when not strongly typed and the Java 8+ focus of Spring Framework 5.0, I tend to vote for the latter.

Any thought? (this is a question we can also discuss during this afternoon meeting)

@spring-projects-issues
Copy link
Collaborator Author

Sébastien Deleuze commented

Fixed by using ZonedDateTime, I will create a follow-up issue targetted for RC3 in order to work on achieving consistency accross at least HttpHeaders API for the kind of property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants