Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider improvements to handling suffixed URL patterns [SPR-15618] #20177

Closed
spring-projects-issues opened this issue Jun 2, 2017 · 1 comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Jun 2, 2017

Andy Clement opened SPR-15618 and commented

See the discussion in #19112 and #20156. It feels like suffixes are a common thing
(patterns ending '.*', '.txt', '.html') and it could be worth special handling for them. Possibly
a new PathElement subtype specifically for suffixed PathElements (because currently "{foo}.*") type patterns are captured as RegexPathElement instances (the least optimal of the PathElement subtypes).

Under #20156 a temporary fix was made to avoid treating '.*' as usage of a wildcard in the PathPattern comparator which feels wrong to some degree (because there is a wildcard there!) but it is what the AntPathMatcher comparator does (See PatternInfo#initCounters()) so it was done to make them consistent.


No further details from SPR-15618

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.x Backlog milestone Jan 11, 2019
@rstoyanchev
Copy link
Contributor

Suffix patterns are already deprecated in Spring MVC and will be turned off by default in 5.3, eventually to be removed. We don't really want to add them here.

@rstoyanchev rstoyanchev removed this from the 5.x Backlog milestone Apr 2, 2020
@rstoyanchev rstoyanchev added the status: declined A suggestion or change that we don't feel we should currently apply label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants