Skip to content

Allow configuration for DEFAULT_FRAME_MAX_SIZE of WebSocketSession on WebFlux with Netty [SPR-16228] #20776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Nov 23, 2017 · 3 comments
Closed

Allow configuration for DEFAULT_FRAME_MAX_SIZE of WebSocketSession on WebFlux with Netty [SPR-16228] #20776

spring-projects-issues opened this issue Nov 23, 2017 · 3 comments
Assignees
@rstoyanchev
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.1 GA

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Nov 23, 2017 •
edited
Loading

Sola opened SPR-16228 and commented

Currently WebSocket in WebFlux with Netty only allows frames that are not over 65536 bytes (in NettyWebSocketSessionSupport#DEFAULT_FRAME_MAX_SIZE)
It would be nice if we can override the default value.

Affects: 5.0.1, 5.0.8

Issue Links:

Referenced from: commits 288a9ec

2 votes, 6 watchers
@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

This is not currently exposed. We need reactor/reactor-netty#223.

@spring-projects-issues
Copy link
Collaborator Author

Rossen Stoyanchev commented

This is not yet available nor scheduled in Reactor Netty so moving to 5.1 GA.

@spring-projects-issues
Copy link
Collaborator Author

Spencer Gibb commented

A spring cloud gateway users are also interested in this.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1 GA milestone Jan 11, 2019
Closed
@spencergibb spencergibb mentioned this issue Jan 31, 2019
Closed
spencergibb added a commit to spencergibb/spring-framework that referenced this issue Jan 31, 2019
@spencergibb
Adds protected method to createWebSocketSession
aeb2e3e 
spring-projects#20776 added the ability to set max frame size for netty websocket support. 

This PR adds the ability to override `createWebSocketSession()` to the new constructor may be called. Users want to be able to do this in Spring Cloud Gateway. Rather than overriding all of execute, we only have to override creation of the class.

See spring-cloud/spring-cloud-gateway#163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.1 GA
Development

No branches or pull requests
2 participants
@rstoyanchev @spring-projects-issues