Update priority for ServerResponseResultHandler [SPR-16420]

[spring-projects-issues]

Rossen Stoyanchev opened SPR-16420 and commented

Currently it's at lowest precedence which seems unnecessarily low and could cause issues. Since it checks by type it should be safe to have a higher precedence.

By comparison ResponseEntity is at 0, ResponseBody is at 100, and view resolution is at lowest precedence. In a mix of functional endpoints and controllers, if the ViewResolutionResultHandler checks first, the ServerResponse would be treated as a model attribute. In that sense view resolution is really meant to be last in line because it ends up making default assumptions broadly applicable to any non-simple type.

I would suggest to use 0, just like ResponseEntity, for the same reason.

---

Affects: 5.0.3

Referenced from: commits fbde97f

[spring-projects-issues]

Rossen Stoyanchev commented

Oops, I see now the order is set explicitly in WebFluxConfigurationSupport to be 1 less than that of view resolution. That explains why it hasn't been issue.

I still think we should align for consistency with other result handlers, by making it a default value, and setting it to 0. Essentially result handlers by type at 0, result handlers by annotation at 100, and view resolution with default assumptions, at lowest.

[spring-projects-issues]

Arjen Poutsma commented

Sounds good.