Performance degradation for creating non-singleton bean [SPR-16514]

[spring-projects-issues]

Jakub Bednar opened SPR-16514 and commented

In our system we use the short live non singleton bean. After upgrade to Spring 5.0.3 our performance tests has performance degradation caused by slowdown the bean creation. Here is a speed comparison between the Spring 4.3.6 and the Spring 5.0.3:

Spring 4.3.6.RELEASE

PerformanceIssue - 1000 bean creations 67 ms
PerformanceIssue - 10000 bean creations 161 ms
PerformanceIssue - 100000 bean creations 222 ms

Spring 5.0.3.RELEASE

PerformanceIssue - 1000 bean creations 100 ms
PerformanceIssue - 10000 bean creations 296 ms
PerformanceIssue - 100000 bean creations 1894 ms

This problem is caused by Assert.notNull in method AnnotationUtils.synthesizeAnnotation. See the YourKit call tree:

Spring 4.3.6.RELEASE
!YourKit-Spring4.png|thumbnail!

Spring 5.0.3.RELEASE
!YourKit-Spring5.png|thumbnail!

• GitHub reproduction project

---

Affects: 5.0.3

Reference URL: https://github.com/bednar/spring-5-performance-issue

Attachments:

• YourKit-Spring4.png (823.23 kB)
• YourKit-Spring5.png (1.02 MB)

Referenced from: commits f316f6a

[spring-projects-issues]

Juergen Hoeller commented

Those extra assertions in AnnotationUtils seem to break some inlining limit in the JVM... Removing superfluous assertions improves bean creation performance by a factor of 4 for me. Streamlined for 5.0.4 now (to be released later today!), with your tests showing much better results.

[spring-projects-issues]

Jakub Bednar commented

Thanks for super fast response. You are awesome! (y)

[spring-projects-issues]

Juergen Hoeller commented

Np, thanks for raising this!

If you have the chance, please give the upcoming 5.0.4.BUILD-SNAPSHOT (https://build.spring.io/browse/SPR-PUB-5807, ready in 5 min) a try for some last-minute pre-release testing on your end...

[spring-projects-issues]

Jakub Bednar commented

I tested the 5.0.4.BUILD-SNAPSHOT build over ours performance tests and everything is back on the track and fine. Thanks

(y)