Incorrect pointcut expressions in reference documentation [SPR-16549]

[spring-projects-issues]

Sviatoslav Hryb opened SPR-16549 and commented

The section Data Access, paragraph 1.5.8. Advising transnational operations contains incorrect pointcut expressions: "execution(!void x.y..Service.(..))" and "execution(\* x.y..Service.(..))" at 3 places as shown in images that is attached.
The correct poincut expressions should be: "execution(!void x.y..\*Service.\*(..))" and "execution(\* x.y..\*Service.\*(..))" accordingly.
h4.
I think that aforementioned section, paragraph 1.5.4. Configuring different transnational semantics for different beans also contains wrong pointcut expression : "execution(\* x.y.service.\*Service.\*(..))" because we point to some class that ends with Service in packet x.y.service, but actually we want to point to any packet that have a root - x.y.service. So the correct pointcut expression should be: "execution(\* x.y.service..\*Service.\*(..))"

---

Affects: 5.0.4

Reference URL: https://docs.spring.io/spring/docs/5.0.4.RELEASE/spring-framework-reference/data-access.html#spring-data-tier

Attachments:

• Bad_Pointcat_Expression1.png (53.25 kB)
• Bad_Pointcat_Expression2_3.png (62.51 kB)
• Wrong_Pointcat_Expression.png (47.17 kB)

Issue Links:

• Incorrect description for class-level @Transactional with AspectJ [SPR-16552] #21095 Incorrect description for class-level @Transactional with AspectJ

Referenced from: commits ff818d5

[spring-projects-issues]

Juergen Hoeller commented

This seems to be an escaping problem in the AsciiDoc format, with those stars interpreted as bold markers. I suppose we need to escape them properly.

[spring-projects-issues]

Juergen Hoeller commented

I've marked the affected source sections as "verbatim" (i.e. no "quotes") which has resolved that issue in other places.