Skip to content

Incorrect description for class-level @Transactional with AspectJ [SPR-16552] #21095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Mar 4, 2018 · 0 comments
Assignees
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Mar 4, 2018

Sviatoslav Hryb opened SPR-16552 and commented

Section Data Access, paragraph 1.5.9. Using @Transactional with AspectJ contains description of using a @Transactional annotation.
But the aforementioned description for the class's annotation is not completely right or clear. There is written: The @Transactional annotation on a class specifies the default transaction semantics for the execution of *any* method in the class. But I've checked the aspect org.springframework.transaction.aspectj.AnnotationTransactionAspect and seen that it is not quite true because it is true only for public methods of the class.
So we should write this: The @Transactional annotation on a class specifies the default transaction semantics for the execution of *any public* method in the class. or something like that.


Affects: 4.3.14, 5.0.4

Reference URL: https://docs.spring.io/spring/docs/5.0.4.RELEASE/spring-framework-reference/data-access.html#transaction-declarative-aspectj

Attachments:

Issue Links:

Referenced from: commits ff818d5, f789895

Backported to: 4.3.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

2 participants