Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassUtils could use long form of Class.forName [SPR-17333] #21867

Closed
spring-projects-issues opened this issue Oct 4, 2018 · 1 comment
Closed

ClassUtils could use long form of Class.forName [SPR-17333] #21867

spring-projects-issues opened this issue Oct 4, 2018 · 1 comment
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
5.1.1

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Oct 4, 2018 •
edited
Loading

Dave Syer opened SPR-17333 and commented

In ClassUtils.isPresent() we prefer ClassLoader.loadClass() to Class.forName(), even though there is a form of Class.forName() that includes the ClassLoader, and also provides the option to not initialize the class (which seems ideal for isPresent()).

(N.B. in Substrate VM Class.forName(className, false, currentLoader) works, for a class that is present, whereas classLoader.loadClass() fails.)

Affects: 5.1 GA

Issue Links:

Referenced from: commits spring-projects/spring-boot@b1d4cf4
@spring-projects-issues
Copy link
Collaborator Author

Dave Syer commented

Same thing applies to org.apache.commons.logging.LogAdapter in spring-jcl. It uses ClassLoader.loadClass() as a proxy for Class.forName().

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1.1 milestone Jan 11, 2019
Closed
@sbrannen sbrannen mentioned this issue Jan 20, 2025
Closed
sbrannen added a commit that referenced this issue Jan 20, 2025
@sbrannen
Remove binary array name handling in ClassUtils.forName()
7fedb9c 
In ClassUtils.forName(), we originally delegated to
ClassLoader.loadClass(), which does not support loading classes from
binary names for arrays (such as "[[I" for "int[][]" or
"[Ljava.lang.String;" for "String[]"); whereas, Class.forName() does
support binary names for arrays.

However, in Spring Framework 5.1.1 we switched from using
ClassLoader.loadClass() to Class.forName() in ClassUtils.forName() (see
gh-21867), which makes our custom handling of binary names for arrays
in ClassUtils.forName() obsolete.

In light of that, this commit removes our custom binary array name
handling support from ClassUtils.forName().

Closes gh-34291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.1
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues