RestTemplate does not throw exception for custom error codes [SPR-17439]

[spring-projects-issues]

shollander opened SPR-17439 and commented

Normally, RestTemplate is expected to throw an exception if the server returns an HTTP error code. However, is the server returns a custom error code (4xx or 5xx), no exception is thrown and the call returns normally.

---

Affects: 4.3.20, 5.0.10

Issue Links:

• RestTemplate doesn't consistently tolerate unknown HTTP status codes [SPR-15978] #20529 RestTemplate doesn't consistently tolerate unknown HTTP status codes
• DefaultResponseErrorHandler.hasError doesn't tolerate unknown status codes [SPR-16108] #20656 DefaultResponseErrorHandler.hasError doesn't tolerate unknown status codes
• RestTemplate.ResponseEntityResponseExtractor doesn't tolerate unknown status codes [SPR-16371] #20918 RestTemplate.ResponseEntityResponseExtractor doesn't tolerate unknown status codes
• DefaultResponseErrorHandler wastes the body of a response with an unknown status [SPR-16604] #21145 DefaultResponseErrorHandler wastes the body of a response with an unknown status
• DefaultResponseErrorHandler does not handle status values outside of HttpStatus enum [SPR-17461] #21993 DefaultResponseErrorHandler does not handle status values outside of HttpStatus enum

Referenced from: commits 97ac1c2, 4a51acb, 1c1b942, 738097d

Backported to: 5.0.11, 4.3.21

[spring-projects-issues]

Rossen Stoyanchev commented

Juergen Hoeller I can see that #20529 brought some changes to DefaultResponseErrorHandler to improve support for custom response codes. Now getHttpStatusCode(ClientHttpResponse) is deprecated in favor of handleError(ClientHttpResponse, HttpStatus) but hasError only detects errors for values in the HttpStatus enum range. So I don't see how handleError would ever be called for a custom 4xx or 5xx code, whereas previously that would have caused an UnknownHttpStatusCodeException.

[spring-projects-issues]

Juergen Hoeller commented

Resolved on master through a raw status code check for client/server errors in case of an unresolvable HttpStatus enum. To be backported to 5.0.x and 4.3.x later today.