Skip to content

AOP support for SPR-17223 & PR#1950 [SPR-17496] #22028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Nov 15, 2018 · 2 comments
Closed

AOP support for SPR-17223 & PR#1950 [SPR-17496] #22028

spring-projects-issues opened this issue Nov 15, 2018 · 2 comments
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Nov 15, 2018

s-mop opened SPR-17496 and commented

In previous commit at PR#1950 we supported register RequestMapping on Interface which implement in parent class.And it works well in our production environment for this 7 weks. See #21756

 

And several days ago I realized that I can't register a AOP cutpoint for the scenario.

So i tried to changed the logic of org.springframework.aop.support.AopUtils.getMostSpecificMethod(Method, Class<?>)

Now this logic will try to find specific method in targetClass's interfaces first.Instead of only do that in targetClass.

I hope this commit can make my PR more helpful;)


Affects: 5.1 GA

Reference URL: c76f017

Issue Links:

Referenced from: pull request #1950

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Alright, I'll have a look at both cases together then...

@rstoyanchev
Copy link
Contributor

Closing along with #21756.

@rstoyanchev rstoyanchev removed this from the 6.x Backlog milestone Dec 3, 2021
@rstoyanchev rstoyanchev added the status: declined A suggestion or change that we don't feel we should currently apply label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants