Skip to content

Stop using libs-* repo in favour of consistent use of Maven Central #23124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Jun 13, 2019 · 8 comments
Closed

Stop using libs-* repo in favour of consistent use of Maven Central #23124

snicoll opened this issue Jun 13, 2019 · 8 comments
Assignees
@snicoll
Labels
type: task A general task
Milestone
5.2 GA

Comments

@snicoll
Copy link
Member

snicoll commented Jun 13, 2019

As we want to make sure we build and release against public artifacts available on Maven Central, let's stop using the libs-* repositories on repo.spring.io that are controlled by us and could potentially contain extra artifacts.
@snicoll snicoll added the type: task A general task label Jun 13, 2019
@snicoll snicoll added this to the 5.2 RC1 milestone Jun 13, 2019
@snicoll snicoll self-assigned this Jun 13, 2019
@snicoll
Copy link
Member Author

snicoll commented Jul 11, 2019 •
edited by sbrannen
Loading

The problem with this approach is that there are a few optional libraries that are not available on Maven central, so we need a repo for those in any case. One approach would be to create a repo that only contains those.

@snicoll
Copy link
Member Author

snicoll commented Jul 11, 2019

The following dependencies non available on Maven Central are currently required by the build:

  • com.ibm.websphere:uow:6.0.2.17
  • io.spring.docresources:spring-doc-resources:0.1.0.RELEASE

For the doc resources, we had a similar problem in Spring Boot and decided to use a different mechanism to retrieve the doc resource (ping @bclozel). Looks like only uow should be made available.

@bclozel bclozel mentioned this issue Jul 12, 2019
Closed
13 tasks
@snicoll
Copy link
Member Author

snicoll commented Jul 12, 2019

@bclozel confirmed spring-doc-resources can be downloaded differently so it looks like we're left with a single dependency to manage.

@snicoll
Copy link
Member Author

snicoll commented Jul 16, 2019

We can use https://repo.spring.io/ext-release-local/ for optional artifacts that aren't on Maven Central.

@snicoll snicoll modified the milestones: 5.2 RC1, 5.2 RC2 Jul 31, 2019
@snicoll snicoll added the status: blocked An issue that's blocked on an external project change label Jul 31, 2019
@snicoll
Copy link
Member Author

snicoll commented Jul 31, 2019

Blocked on #23282

bclozel added a commit that referenced this issue Aug 20, 2019
@bclozel
Download docs resources as zip file in asciidoc build
b3aebf9 
Prior to this commit, the reference documentation build with asciidoctor
would get the common "spring-docs-resources" as a dependency and then
use it when generating the docs.

As seen in #23124, this can cause problems since we'd like to
consistently resolve our dependencies. In this case, the
"spring-doc-resources" archive is not published on maven central since
it's not officially supported by the Spring team as an open source
project.

This commit updates the reference documentation build to get this
archive as a simple download task and avoid resolving it as a
dependency.

See gh-23282
@bclozel bclozel removed the status: blocked An issue that's blocked on an external project change label Aug 20, 2019
@bclozel
Copy link
Member

bclozel commented Aug 23, 2019

@snicoll this task is not blocked anymore from our asciidoc build's perspective.

snicoll added a commit that referenced this issue Aug 28, 2019
@snicoll
Stop using mavenLocal()
46b3a83 
This commit makes sure the content of the local maven repository has no
impact on the build

See gh-23124
@snicoll snicoll reopened this Aug 28, 2019
snicoll added a commit that referenced this issue Aug 28, 2019
@snicoll
Revert "Stop using libs-release"
5a28fdc 
This reverts commit e5b9571.

See gh-23124
@snicoll
Copy link
Member Author

snicoll commented Aug 28, 2019

Unfortunately, we're using a new resource that is not on Maven Central, io.spring.asciidoctor:spring-asciidoctor-extensions:0.1.3.RELEASE. It's only used for doc generation and moving that to the ext-release-local repo doesn't make sense to me so we're back to the idea of having a dedicated repo for the build

@snicoll snicoll modified the milestones: 5.2 RC2, 5.2 GA Sep 5, 2019
@snicoll
Copy link
Member Author

snicoll commented Sep 19, 2019

We have now a new virtual repo (libs-spring-framework-build) that contains the uow dependency and the asciidoctor extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
5.2 GA
Development

No branches or pull requests
2 participants
@bclozel @snicoll