Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for PathPatternParser in Spring MVC #24945

Closed
rstoyanchev opened this issue Apr 20, 2020 · 0 comments
Closed

Support for PathPatternParser in Spring MVC #24945

rstoyanchev opened this issue Apr 20, 2020 · 0 comments
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.3 M1

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Apr 20, 2020 •
edited
Loading

Spring MVC has always used AntPathMatcher but the use of patterns has grown over time with annotated controllers and URI variables present in most patterns. This is why for WebFlux we introduced PathPatternParser and the parsed PathPattern representation which enables more efficient path matching.

This issue is to add support for using PathPattern in Spring MVC as an alternative to the AntPathMatcher which will also require using a RequestPath, a parsed representation of the request path.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Apr 20, 2020
@rstoyanchev rstoyanchev added this to the 5.3 M1 milestone Apr 20, 2020
@rstoyanchev rstoyanchev self-assigned this Apr 20, 2020
@rstoyanchev rstoyanchev mentioned this issue Apr 20, 2020
Closed
@ranarula ranarula mentioned this issue Apr 21, 2020
Closed
@rstoyanchev rstoyanchev mentioned this issue Apr 24, 2020
Closed
@rstoyanchev rstoyanchev changed the title Path Matching via Parsed Patterns in Spring MVC Support for PathPatternParser in Spring MVC Jun 2, 2020
@rstoyanchev rstoyanchev mentioned this issue Jun 2, 2020
Closed
@bclozel bclozel mentioned this issue Jun 4, 2020
Closed
rstoyanchev added a commit that referenced this issue Jun 15, 2020
@rstoyanchev
Support for parsed PathPatterns in Spring MVC
5225a57 
See gh-24945
@rstoyanchev rstoyanchev mentioned this issue Jun 15, 2020
Closed
rstoyanchev added a commit that referenced this issue Jun 15, 2020
@rstoyanchev
HandlerMappings expose usesPathPatterns() method
b572f76 
See gh-24945
kenny5he pushed a commit to kenny5he/spring-framework that referenced this issue Jun 21, 2020
@rstoyanchev @kenny5he
Support for parsed PathPatterns in Spring MVC
f279258 
See spring-projectsgh-24945
kenny5he pushed a commit to kenny5he/spring-framework that referenced this issue Jun 21, 2020
@rstoyanchev @kenny5he
HandlerMappings expose usesPathPatterns() method
6169f7b 
See spring-projectsgh-24945
kenny5he pushed a commit to kenny5he/spring-framework that referenced this issue Jun 21, 2020
@rstoyanchev @kenny5he
Update docs for PathPattern support in WebMvc
a1db26b 
Closes spring-projectsgh-24945
rstoyanchev added a commit that referenced this issue Jun 23, 2020
@rstoyanchev
Set PathPatternParser in RouterFunctionMapping
837dfe2 
See gh-24945
rstoyanchev added a commit that referenced this issue Jun 24, 2020
@rstoyanchev
Direct matches by URL path work again
57f868f 
This commit fixes a recent regression as a result of 5225a57
with the determination of non-pattern vs pattern URLs. That in turn affects the ability to perform
direct matches by URL path.

There is also a fix in PathPattern to recognize "catch-all" patterns as pattern syntax.

See gh-24945
@rstoyanchev rstoyanchev mentioned this issue Jun 24, 2020
Closed
@yoshikawaa yoshikawaa mentioned this issue Aug 24, 2020
Closed
jhoeller added a commit that referenced this issue Nov 16, 2020
@jhoeller
Consistent attribute value spelling for PATH_ATTRIBUTE
7206a23 
See gh-24945
@rstoyanchev rstoyanchev mentioned this issue Feb 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3 M1
Development

No branches or pull requests
1 participant
@rstoyanchev