Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Gradle 7.2 #26870

Closed
3 tasks done
quaff opened this issue Apr 28, 2021 · 6 comments
Closed
3 tasks done

Upgrade to Gradle 7.2 #26870

quaff opened this issue Apr 28, 2021 · 6 comments
Assignees
@bclozel @sbrannen
Labels
type: task A general task
Milestone
5.3.10

Comments

@quaff
Copy link
Contributor

quaff commented Apr 28, 2021 •
edited by bclozel
Loading

Here is tasks I can remember
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 28, 2021
@bclozel bclozel self-assigned this May 21, 2021
@bclozel bclozel added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 21, 2021
@bclozel bclozel added this to the 5.3.8 milestone May 21, 2021
@bclozel bclozel modified the milestones: 5.3.8, 5.x Backlog Jun 1, 2021
@bclozel bclozel added the status: blocked An issue that's blocked on an external project change label Jun 1, 2021
@bclozel
Copy link
Member

bclozel commented Jun 1, 2021

I've got a draft commit for this, fixing quite a few things in our build. The dokka plugin version we're using is not compatible with Gradle 7 and after checking with the team, we should probably wait for the 1.5.0 version.

I'm moving this back to the backlog and marking it as blocked in the meantime.

@sbrannen sbrannen changed the title Upgrade to gradle 7.0 Upgrade to Gradle 7.1 Jun 15, 2021
@sbrannen
Copy link
Member

In the meantime, Gradle 7.1 has been released.

@bclozel bclozel changed the title Upgrade to Gradle 7.1 Upgrade to Gradle 7.2 Sep 6, 2021
@bclozel
Copy link
Member

bclozel commented Sep 6, 2021

I've got a draft commit for this issue here.

The build runs fine but the dokka generation takes 10+min on my laptop and the result is quite large (almost 40MB). I'm wondering if I've messed up the configuration or if there's a way to limit the scope here so that the plugin has less things to consider. The new version of the plugin simplifies our setup quite a bit.

@sdeleuze Could you have a look here?

You can locally trigger the generation with: ./gradlew dokkaHtmlMultiModule --no-scan --info.

@bclozel bclozel removed the status: blocked An issue that's blocked on an external project change label Sep 13, 2021
@bclozel bclozel modified the milestones: 5.x Backlog, 5.2.17 Sep 13, 2021
bclozel added a commit that referenced this issue Sep 13, 2021
@bclozel
Upgrade to Gradle 7.2
cecc084 
This commit upgrades Gradle to 7.2.
Gradle configuration names are updated accordingly.
This also upgrades Gradle build plugins.

See gh-26870
bclozel pushed a commit that referenced this issue Sep 13, 2021
@sdeleuze @bclozel
Update dokka to 1.5.0
ab41db4 
See gh-26870
@quaff
Copy link
Contributor Author

quaff commented Sep 13, 2021

  1. The Report.destination property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the outputLocation property instead. See https://docs.gradle.org/7.2/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:destination for more details.

  2. The JavaExec.main property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the mainClass property instead. See https://docs.gradle.org/7.2/dsl/org.gradle.api.tasks.JavaExec.html#org.gradle.api.tasks.JavaExec:main for more details.

@sbrannen
Copy link
Member

Thanks, @quaff.

We've noticed those warnings as well.

Reopening to address those two warnings.

I'll address the first one for spring-test.

@sbrannen sbrannen reopened this Sep 13, 2021
@bclozel bclozel modified the milestones: 5.2.17, 5.3.10 Sep 13, 2021
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 13, 2021
@sbrannen
Avoid use of deprecated API in aggregateTestReports task
d55cbf8 
See spring-projectsgh-26870
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Sep 14, 2021
@sbrannen
Upgrade to nohttp 0.0.10
8c14251 
This upgrade avoids warnings about the following on Gradle 7.1+.

- The Report.destination property has been deprecated.
- The JavaExec.main property has been deprecated.

See spring-projectsgh-26870
@sbrannen sbrannen self-assigned this Sep 14, 2021
@snicoll

This comment has been minimized.

Sign in to view
lazy-snail pushed a commit to lazy-snail/spring-framework that referenced this issue Sep 14, 2021
@sbrannen @lazy-snail
Upgrade to nohttp 0.0.10
b18a4ba 
This upgrade avoids warnings about the following on Gradle 7.1+.

- The Report.destination property has been deprecated.
- The JavaExec.main property has been deprecated.

See spring-projectsgh-26870
lazy-snail pushed a commit to lazy-snail/spring-framework that referenced this issue Sep 14, 2021
@sbrannen @lazy-snail
Avoid usage of deprecated Gradle API in spring-oxm.gradle
d742ce8 
This upgrade avoids the warning about the following on Gradle 7.1+.

- The SourceDirectorySet.outputDir property has been deprecated.

Closes spring-projectsgh-26870
sbrannen added a commit that referenced this issue Sep 14, 2021
@sbrannen
Re-enable import into Eclipse IDE
3faf445 
The migration to Gradle 7.2 resulted in a regression for our Eclipse
IDE support: several projects ended up with recursive classpath entries
in their generated .classpath files which prevent those projects from
being built within Eclipse.

This commit addresses this issue with a solution that may well be a
"hack". Nonetheless, a working hack is better than not being able to
import into Eclipse at all.

See gh-26870
@sbrannen sbrannen mentioned this issue Sep 15, 2021
Closed
12 tasks
@jhoeller jhoeller mentioned this issue Nov 11, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@bclozel @lxbzmy
Upgrade to Gradle 7.2
afa0cdf 
This commit upgrades Gradle to 7.2.
Gradle configuration names are updated accordingly.
This also upgrades Gradle build plugins.

See spring-projectsgh-26870
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sdeleuze @lxbzmy
Update dokka to 1.5.0
f06182e 
See spring-projectsgh-26870
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@bclozel @lxbzmy
Polish Gradle upgrade
9e711c1 
Closes spring-projectsgh-26870
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Avoid use of deprecated API in aggregateTestReports task
7e7766e 
See spring-projectsgh-26870
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Upgrade to nohttp 0.0.10
a9c23f4 
This upgrade avoids warnings about the following on Gradle 7.1+.

- The Report.destination property has been deprecated.
- The JavaExec.main property has been deprecated.

See spring-projectsgh-26870
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Avoid usage of deprecated Gradle API in spring-oxm.gradle
a7776ae 
This upgrade avoids the warning about the following on Gradle 7.1+.

- The SourceDirectorySet.outputDir property has been deprecated.

Closes spring-projectsgh-26870
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Re-enable import into Eclipse IDE
43f3317 
The migration to Gradle 7.2 resulted in a regression for our Eclipse
IDE support: several projects ended up with recursive classpath entries
in their generated .classpath files which prevent those projects from
being built within Eclipse.

This commit addresses this issue with a solution that may well be a
"hack". Nonetheless, a working hack is better than not being able to
import into Eclipse at all.

See spring-projectsgh-26870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

@sbrannen sbrannen

Labels
type: task A general task
Projects
None yet
Milestone
5.3.10
Development

No branches or pull requests
5 participants
@bclozel @sbrannen @quaff @snicoll @spring-projects-issues