Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure multipart temp directories do not collide #26931

Closed
poutsma opened this issue May 11, 2021 · 2 comments
Closed

Ensure multipart temp directories do not collide #26931

poutsma opened this issue May 11, 2021 · 2 comments
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.3.7

Comments

@poutsma
Copy link
Contributor

poutsma commented May 11, 2021

The SynchronossPartHttpMessageReader needs separate directories to store uploaded files in, or otherwise multiple instances might collide.

The same applies to the DefaultPartHttpMessageReader.
@poutsma poutsma self-assigned this May 11, 2021
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels May 11, 2021
@poutsma poutsma added this to the 5.3.7 milestone May 11, 2021
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.2.x labels May 11, 2021
Closed
poutsma added a commit that referenced this issue May 11, 2021
@poutsma
Ensure Synchronoss temp directories do not collide
85ad63b 
This commit makes sure that Synchronoss uses a random temporary
directory to store uploaded files, so that two instances do not collide.

Closes gh-26931
poutsma added a commit that referenced this issue May 11, 2021
@poutsma
Ensure DefaultPartHttpMessageReader temp directories do not collide
0d0d75e 
This commit makes sure that the DefaultPartHttpMessageReader uses a
random temporary directory to store uploaded files, so that two
instances do not collide.

See gh-26931
@sync-by-unito sync-by-unito bot mentioned this issue May 12, 2021
Merged
@tcherel
Copy link

tcherel commented Jun 2, 2021

@poutsma might be a stupid question (not very familiar with Spring) but is there an easy way to figure which spring artifacts (https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Artifacts) are actually impacted by this change (short of downloading all of them an checking which one(s) contains the modified classes)?

@poutsma
Copy link
Contributor Author

poutsma commented Jun 3, 2021

The commits (cce60c4 and 0d0d75e) show that changes were made in the spring-web module.

@poutsma poutsma mentioned this issue Jun 22, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@poutsma @lxbzmy
Ensure Synchronoss temp directories do not collide
4b0e1ff 
This commit makes sure that Synchronoss uses a random temporary
directory to store uploaded files, so that two instances do not collide.

Closes spring-projectsgh-26931
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@poutsma @lxbzmy
Ensure DefaultPartHttpMessageReader temp directories do not collide
332257d 
This commit makes sure that the DefaultPartHttpMessageReader uses a
random temporary directory to store uploaded files, so that two
instances do not collide.

See spring-projectsgh-26931
@AASMACMX AASMACMX mentioned this issue Jul 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.7
Development

No branches or pull requests
3 participants
@poutsma @spring-projects-issues @tcherel