Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention explicitly that @EventListener should be put on public methods #27777

Closed
snicoll opened this issue Dec 7, 2021 · 7 comments
Closed

Mention explicitly that @EventListener should be put on public methods #27777

snicoll opened this issue Dec 7, 2021 · 7 comments
Assignees
@snicoll
Labels
status: invalid An issue that we don't feel is valid type: documentation A documentation task

Comments

@snicoll
Copy link
Member

snicoll commented Dec 7, 2021

any method should rather be any public method in this section
@snicoll snicoll added the type: documentation A documentation task label Dec 7, 2021
@snicoll snicoll added this to the 5.3.14 milestone Dec 7, 2021
@snicoll snicoll self-assigned this Dec 7, 2021
@yezhiweier

This comment has been minimized.

Sign in to view
@yangguang001

This comment has been minimized.

Sign in to view
@hklisuper

This comment has been minimized.

Sign in to view
@xmt1139057136

This comment has been minimized.

Sign in to view
@crazycodeon

This comment has been minimized.

Sign in to view
@spring-projects spring-projects locked and limited conversation to collaborators Dec 7, 2021
@snicoll snicoll closed this as completed in 57a5370 Dec 9, 2021
@sbrannen
Copy link
Member

sbrannen commented Dec 9, 2021

any method should rather be any public method in this section

This effectively reverts #26785.

Is there a requirement that such methods be public?

@snicoll snicoll reopened this Dec 9, 2021
@snicoll
Copy link
Member Author

snicoll commented Dec 9, 2021

I got confused by an external report, I'll have to get back to the user.

@snicoll snicoll closed this as completed Dec 9, 2021
@snicoll snicoll added the status: invalid An issue that we don't feel is valid label Dec 9, 2021
@snicoll snicoll removed this from the 5.3.14 milestone Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@snicoll snicoll

Labels
status: invalid An issue that we don't feel is valid type: documentation A documentation task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sbrannen @snicoll @yezhiweier @yangguang001 @hklisuper @xmt1139057136 @crazycodeon