Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve @EventListener documentation in reference manual #26785

Closed
wants to merge 1 commit into from
Closed

Improve @EventListener documentation in reference manual #26785

wants to merge 1 commit into from

Conversation

hrybs
Copy link
Contributor

@hrybs hrybs commented Apr 10, 2021

  1. According to a source code of ApplicationListenerMethodAdapter class we can see that return type of a method annotated with @eventlistener can be not only a Collection<?> but also array.
  2. Method annotated with @eventlistener can have any visibility (public, protected, package-private and private) and can be final and static.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 10, 2021
@sbrannen sbrannen self-assigned this Apr 13, 2021
@sbrannen sbrannen added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 13, 2021
@sbrannen sbrannen changed the title fix EventListener annotation description Improve @EventListener documentation in reference manual Apr 13, 2021
@sbrannen sbrannen closed this in a80c5fc Apr 13, 2021
sbrannen added a commit that referenced this pull request Apr 13, 2021
@sbrannen
Polish contribution
bcc6171 
See gh-26785
@sbrannen sbrannen added this to the 5.3.6 milestone Apr 13, 2021
@sbrannen
Copy link
Member

This has been merged into master in a80c5fc and revised in bcc6171.

Thanks

@sbrannen sbrannen mentioned this pull request Dec 9, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@hrybs @lxbzmy
Improve @eventlistener documentation in reference manual
67d7c8a 
Closes spring-projectsgh-26785
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this pull request Mar 26, 2022
@sbrannen @lxbzmy
Polish contribution
12f4b24 
See spring-projectsgh-26785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
type: task A general task
Projects
None yet
Milestone
5.3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@hrybs @sbrannen @spring-projects-issues