Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationTypeMapping tracks @AliasFor mappings as convention-based #28773

Closed
sbrannen opened this issue Jul 7, 2022 · 0 comments
Closed

AnnotationTypeMapping tracks @AliasFor mappings as convention-based #28773

sbrannen opened this issue Jul 7, 2022 · 0 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Jul 7, 2022

While working on #28760, I noticed that AnnotationTypeMapping.addConventionMappings() actually adds convention-based mappings that it should not.

For example, in certain circumstances an explicit annotation attribute override configured via @AliasFor can be mapped as convention-based.

Although this does not appear to cause negative side effects (other than unnecessary processing), this is technically a bug that should be addressed.

However, since there may be unknown use cases that somehow rely on the behavior of this bug, I currently only intend to apply the fix to 6.0.

@sbrannen sbrannen added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Jul 7, 2022
@sbrannen sbrannen added this to the 6.0.0-M5 milestone Jul 7, 2022
@sbrannen sbrannen self-assigned this Jul 7, 2022
@sbrannen sbrannen changed the title AnnotationTypeMapping tracks @AliasFor mappings a convention-based AnnotationTypeMapping tracks @AliasFor mappings as convention-based Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Development

No branches or pull requests

1 participant