Skip to content

Support sending large STOMP messages as fragmented frames #29354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
totakura opened this issue Oct 19, 2022 · 4 comments
Closed

Support sending large STOMP messages as fragmented frames #29354

totakura opened this issue Oct 19, 2022 · 4 comments
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@totakura
Copy link

totakura commented Oct 19, 2022 •
edited
Loading

#16152 added handling of fragmented STOMP frames. However, as of now there is no functionality to send such fragmented frames through WebSocketStompClient. This issue is a feature request to add complimentary functionality in WebSocketStompClient.

Node libraries such as stompjs https://stomp-js.github.io/ allow for configuring a max chunk size. When STOMP message is bigger than the chunk size, it is sent as multiple websocket frames.

We would also need to expose the functionality to configure the max chunk size in WebSocketStompClient.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 19, 2022
@rishiraj88
Copy link

Apt feature request, @totakura .

@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Jan 31, 2023
@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 21, 2023
@jhoeller jhoeller added this to the General Backlog milestone Dec 21, 2023
@injae-kim
Copy link
Contributor

injae-kim commented Jan 5, 2024 •
edited
Loading

May I handle this issue? I checked stomp.js send&receive fragments impl details, stomp protocol spec doc and I think I can implement this!

I'll create PR until 2024/01/14 next weekend. thanks! 🙇

@injae-kim injae-kim mentioned this issue Jan 7, 2024
Closed
@injae-kim
Copy link
Contributor

injae-kim commented Jan 7, 2024 •
edited
Loading

I create PR #31970 to resolve this issue~! 😄

@rstoyanchev
Copy link
Contributor

Thanks, @injae-kim. I'll close this in favor of the PR.

@rstoyanchev rstoyanchev closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
@rstoyanchev rstoyanchev removed this from the General Backlog milestone Jan 9, 2024
@rstoyanchev rstoyanchev added the status: superseded An issue that has been superseded by another label Jan 9, 2024
injae-kim added a commit to injae-kim/spring-framework that referenced this issue Jan 14, 2024
@injae-kim
Support sending large STOMP messages as fragmented frames on `WebSock…
05a990e 
…etStompClient`

Closes spring-projectsgh-29354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
7 participants
@sbrannen @rstoyanchev @jhoeller @totakura @rishiraj88 @spring-projects-issues @injae-kim