Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LocalVariableTableParameterNameDiscoverer #29559

Closed
jhoeller opened this issue Nov 23, 2022 · 1 comment
Closed

Remove LocalVariableTableParameterNameDiscoverer #29559

jhoeller opened this issue Nov 23, 2022 · 1 comment
Assignees
@jhoeller
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone
6.1.0-M1

Comments

@jhoeller
Copy link
Contributor

Following up on #29531, we intend to remove LocalVariableTableParameterNameDiscoverer completely in 6.1. It is entirely superseded by StandardReflectionParameterNameDiscoverer and only serves an outdated fallback after the latter in DefaultParameterNameDiscoverer still. Since it performs blocking class file parsing and does not work in a native image, it has no remaining role anymore.

For the transition period up until then, as per #29531, it logs a warning for every successful resolution attempt - that is, where StandardReflectionParameterNameDiscoverer did not find names retained through -parameters compilation before.
@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Nov 23, 2022
@jhoeller jhoeller added this to the 6.1.x milestone Nov 23, 2022
@jhoeller jhoeller self-assigned this Nov 23, 2022
jhoeller added a commit that referenced this issue Nov 23, 2022
@jhoeller
Retain default LocalVariableTableParameterNameDiscoverer with warn lo…
fe5bd67 
…g entries

For a transition period, LocalVariableTableParameterNameDiscoverer logs a warning for each successful resolution attempt now, suggesting that -parameters was missed.

See gh-29531
See gh-29559
@wilkinsona wilkinsona mentioned this issue Nov 23, 2022
Closed
@jhoeller jhoeller modified the milestones: 6.1.x, 6.1.0-M1 Jan 10, 2023
@sbrannen
Copy link
Member

Reopening to ensure this is covered in the Upgrading to Version 6.1 notes.

@sbrannen sbrannen reopened this May 17, 2023
izeye added a commit to izeye/spring-framework that referenced this issue Jun 7, 2023
@izeye
Remove LocalVariableTableParameterNameDiscoverer reference in doc
0971ec1 
See spring-projectsgh-29559
@izeye izeye mentioned this issue Jun 7, 2023
Merged
sbrannen pushed a commit that referenced this issue Jun 7, 2023
@izeye
Remove LocalVariableTableParameterNameDiscoverer reference in doc
7c817dd 
See gh-29559
Closes gh-30611
@mp911de mp911de mentioned this issue Jun 13, 2023
Closed
@jzheaux jzheaux mentioned this issue Jul 17, 2023
Closed
marcusdacoregio added a commit to spring-projects/spring-session that referenced this issue Jul 18, 2023
@marcusdacoregio
Compile with -parameters
10b08d3 
See spring-projects/spring-framework#29559
@bclozel bclozel mentioned this issue Aug 23, 2023
Closed
@sbrannen sbrannen mentioned this issue Sep 5, 2023
Closed
@scottfrederick scottfrederick mentioned this issue Nov 3, 2023
Closed
@philwebb philwebb mentioned this issue Nov 21, 2023
Closed
@sbrannen sbrannen mentioned this issue Nov 24, 2023
Closed
@mfvanek mfvanek mentioned this issue Dec 1, 2023
Closed
This was referenced Dec 20, 2023
Closed
Closed
@fatso83 fatso83 mentioned this issue Jan 10, 2024
Closed
@vietnguyen vietnguyen mentioned this issue Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M1
Development

No branches or pull requests
2 participants
@sbrannen @jhoeller