Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow MockRest to match header/queryParam value list with one Matcher #29964

Closed
github-actions bot opened this issue Feb 13, 2023 · 0 comments
Closed

Allow MockRest to match header/queryParam value list with one Matcher #29964

github-actions bot opened this issue Feb 13, 2023 · 0 comments
Assignees
@simonbasle
Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Milestone
5.3.26

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023 •
edited by simonbasle
Loading

Backport of gh-29953
@github-actions github-actions bot added in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) status: superseded An issue that has been superseded by another type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement labels Feb 13, 2023
@github-actions github-actions bot added this to the 5.3.26 milestone Feb 13, 2023
@simonbasle simonbasle removed the status: superseded An issue that has been superseded by another label Feb 13, 2023
@simonbasle simonbasle changed the title Add support in MockRestServiceServer to assert ALL header and queryParam values with a single Matcher Allow MockRest to match header/queryParam value list with one Matcher Feb 13, 2023
simonbasle added a commit that referenced this issue Feb 13, 2023
@simonbasle
Allow MockRest to match header/queryParam value list with one Matcher
7f2c93f 
This commit adds a `header` variant and a `queryParam` variant to the
`MockRestRequestMatchers` API which take a single `Matcher` over the
list of values.

Contrary to the vararg variants, the whole list is evaluated and the
caller can choose the desired semantics using readily-available iterable
matchers like `everyItem`, `hasItems`, `hasSize`, `contains` or
`containsInAnyOrder`...

The fact that the previous variants don't strictly check the size of the
actual list == the number of provided matchers or expected values is
now documented in their respective javadocs.

See gh-29953
Closes gh-29964
@izeye izeye mentioned this issue Feb 16, 2023
Merged
sbrannen pushed a commit that referenced this issue Feb 19, 2023
@izeye
Fix Javadoc since for MockRestRequestMatchers queryParam() and header…
2d62be8 
…() (#29986)

See gh-29953
See gh-29964
sbrannen added a commit that referenced this issue Feb 19, 2023
@sbrannen
Revise queryParam() and header() support in MockRestRequestMatchers
8a44b64 
See gh-29953
See gh-29964
sbrannen pushed a commit to sbrannen/spring-framework that referenced this issue Feb 22, 2023
@izeye @sbrannen
Fix Javadoc since for MockRestRequestMatchers queryParam() and header…
2b4b947 
…() (spring-projects#29986)

See spring-projectsgh-29953
See spring-projectsgh-29964
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Feb 22, 2023
@sbrannen
Revise queryParam() and header() support in MockRestRequestMatchers
423134f 
See spring-projectsgh-29953
See spring-projectsgh-29964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonbasle simonbasle

Labels
in: test Issues in the test module in: web Issues in web modules (web, webmvc, webflux, websocket) type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.26
Development

No branches or pull requests
2 participants
@jhoeller @simonbasle