Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataSource configuration/exposure to LocalEntityManagerFactoryBean #32344

Closed
jhoeller opened this issue Feb 28, 2024 · 0 comments
Closed
Assignees
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Milestone

Comments

@jhoeller
Copy link
Contributor

In contrast to the commonly used LocalContainerEntityManagerFactoryBean, the simpler LocalEntityManagerFactoryBean does not accept or expose a JDBC DataSource reference. Based on the "jakarta.persistence.dataSource" property (which can be used for passing in a DataSource reference via our jpaPropertyMap already), a setDataSource method and in particular a getDataSource method for autodetection in JpaTransactionManager are worth exposing.

Further configuration options could be added to LocalEntityManagerFactoryBean based on JPA 3.2, once we are on a Jakarta EE 11 baseline; see #31157 (comment).

@jhoeller jhoeller added in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement labels Feb 28, 2024
@jhoeller jhoeller added this to the 6.2.0-M1 milestone Feb 28, 2024
@jhoeller jhoeller self-assigned this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant