OverrideMetadata equals/hashCode should rely on getClass()

[snicoll]

equals and hashCode implementations in MockitoSpyBeanOverrideMetadata care about getClass() but shouldn't:

spring-framework/spring-test/src/main/java/org/springframework/test/context/bean/override/mockito/MockitoSpyBeanOverrideMetadata.java

Lines 105 to 109 in 28f62ab

	}
	// For SpyBean we want the class to be exactly the same.
	if (other == null || other.getClass() != getClass()) {
	return false;
	}

This looks like a copy/paste from the Spring Boot implementation that doesn't have the notion of BeanOverrideStrategy that is enough already to differentiate between those two.

[snicoll]

Looking a bit more after having removed that code, it turns out things are working but could stop if someone created an OverrideMetadata with the same settings in a different class. For instance something similar to TestBeanOverrideMetadata but with a completely different approach to how the override is created. While very unlikely, harmonizing equals/hashCode so that the OverrideMetadata implementation is part of the key sounds sensible.