Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dedicated async dispatch support for MockMvcTester #33040

Closed
snicoll opened this issue Jun 16, 2024 · 1 comment
Closed

Add dedicated async dispatch support for MockMvcTester #33040

snicoll opened this issue Jun 16, 2024 · 1 comment
Assignees
@snicoll
Labels
in: test Issues in the test module type: enhancement A general enhancement
Milestone
6.2.0-M5

Comments

@snicoll
Copy link
Member

snicoll commented Jun 16, 2024 •
edited
Loading

Similar to #33027 but for async requests that require two requests to be issued (one to start the async processing, and one to actually do the dispatch).

I am not sure why we'd need those to be separated for the AssertJ support since it's stateful.

This could be one of those cases where we want to take the current response as an input parameter and produce an Assert object that results from performing another exchange using that input.
@snicoll snicoll added in: test Issues in the test module type: enhancement A general enhancement labels Jun 16, 2024
@snicoll snicoll added this to the 6.2.x milestone Jun 16, 2024
@snicoll snicoll changed the title Add dedicated async dispatch for MockMvcTester Add dedicated async dispatch support for MockMvcTester Jun 16, 2024
@snicoll snicoll self-assigned this Jun 17, 2024
@snicoll snicoll modified the milestones: 6.2.x, 6.2.0-M5 Jun 18, 2024
snicoll added a commit that referenced this issue Jun 18, 2024
@snicoll
Improve support of async request in MockMvcTester
24bbc6d 
This commit improves the handling of asynchronous requests by offering
a way to opt-in for the raw async result. This provides first class
support for asserting a request that might still be in process as well
as the asyncResult, if necessary.

See gh-33040
@snicoll
Copy link
Member Author

snicoll commented Jun 18, 2024

Thanks to @wilkinsona for a review. This has been improved in 24bbc6d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-M5
Development

No branches or pull requests
1 participant
@snicoll