Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify static resource location ends on slash #33712

Closed
rstoyanchev opened this issue Oct 15, 2024 · 1 comment
Closed

Verify static resource location ends on slash #33712

rstoyanchev opened this issue Oct 15, 2024 · 1 comment
Assignees
@rstoyanchev
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.2.0-RC2

Comments

@rstoyanchev
Copy link
Contributor

A location that does not end on "/" does not actually work as intended, which is probably why it hasn't been reported as an issue. We should append the slash where we can, e.g. String location values, and assert Resource locations.
@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Oct 15, 2024
@rstoyanchev rstoyanchev added this to the 6.2.0-RC2 milestone Oct 15, 2024
@rstoyanchev rstoyanchev self-assigned this Oct 15, 2024
rstoyanchev added a commit that referenced this issue Oct 15, 2024
@rstoyanchev
Update Javadoc snippets for static resource locations
a63cf06 
Switch to FileUrlResource, the same as what is used get with
the "file:" prefix in webmvc and webflux config.

See gh-33712
@cagliostro92
Copy link

cagliostro92 commented Oct 29, 2024 •
edited
Loading

A location that does not end on "/" does not actually work as intended, which is probably why it hasn't been reported as an issue. We should append the slash where we can, e.g. String location values, and assert Resource locations.

@rstoyanchev I know this is already closed, but I'm wondering why actual code doesn't try at all to append a slash, but it simply throws an exception if the slash isn't already present.

@philwebb philwebb mentioned this issue Oct 29, 2024
Closed
@cagliostro92 cagliostro92 mentioned this issue Oct 30, 2024
Closed
@rstoyanchev rstoyanchev mentioned this issue Oct 31, 2024
Closed
@bclozel bclozel mentioned this issue Dec 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rstoyanchev rstoyanchev

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.0-RC2
Development

No branches or pull requests
2 participants
@rstoyanchev @cagliostro92