Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing converters to DefaultRestClientBuilder #34439

Closed
sdeleuze opened this issue Feb 17, 2025 · 0 comments
Closed

Add missing converters to DefaultRestClientBuilder #34439

sdeleuze opened this issue Feb 17, 2025 · 0 comments
Assignees
@sdeleuze
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement
Milestone
6.2.4

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Feb 17, 2025 •
edited
Loading

Some converters like CBOR and Protobuf Kotlin Serialization ones are activated if detected in RestTemplate but not in DefaultRestClientBuilder. Probably an oversight.
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement labels Feb 17, 2025
@sdeleuze sdeleuze added this to the 6.2.4 milestone Feb 17, 2025
@sdeleuze sdeleuze self-assigned this Feb 17, 2025
@sdeleuze sdeleuze changed the title Add missing Kotlin Serialization converters to DefaultRestClientBuilder Add missing converters to DefaultRestClientBuilder Feb 18, 2025
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Feb 18, 2025
@sdeleuze
Polishing
2099e04 
See spring-projectsgh-34439
pankratz76 pushed a commit to pankratz76/spring-framework that referenced this issue Feb 24, 2025
@sdeleuze @pinguin3245678
Add missing converters to DefaultRestClientBuilder
d0d4748 
With this commit, DefaultRestClientBuilder configures the same
default converters than RestTemplate.

Closes spring-projectsgh-34439

Signed-off-by: Vincent Potucek <vincent.potucek@sap.com>

# Conflicts:
#	spring-web/src/main/java/org/springframework/web/client/DefaultRestClientBuilder.java
#	spring-web/src/main/java/org/springframework/web/client/RestTemplate.java
pankratz76 pushed a commit to pankratz76/spring-framework that referenced this issue Feb 24, 2025
@sdeleuze @pinguin3245678
Polishing
78c4a33 
See spring-projectsgh-34439

Signed-off-by: Vincent Potucek <vincent.potucek@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: kotlin An issue related to Kotlin support type: enhancement A general enhancement
Projects
None yet
Milestone
6.2.4
Development

No branches or pull requests
1 participant
@sdeleuze