Skip to content

Introduce Stream variant methods for SqlQuery #34474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
quaff opened this issue Feb 24, 2025 · 2 comments · Fixed by #34623
Closed

Introduce Stream variant methods for SqlQuery #34474

quaff opened this issue Feb 24, 2025 · 2 comments · Fixed by #34623
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement

Comments

@quaff
Copy link
Contributor

quaff commented Feb 24, 2025

queryForStream() was introduced for JdbcOperations since 5.3, It would be nice if SqlQuery could leverage it to process large result too.

I would like to prepare PR if the proposal is accepted.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 24, 2025
@sbrannen sbrannen added the in: data Issues in data modules (jdbc, orm, oxm, tx) label Feb 24, 2025
@jhoeller jhoeller added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 19, 2025
@jhoeller jhoeller added this to the 7.0.x milestone Mar 19, 2025
@jhoeller
Copy link
Contributor

Sounds good, let's consider that for 7.0 then.

quaff added a commit to quaff/spring-framework that referenced this issue Mar 20, 2025
@quaff
Introduce Stream variant methods for SqlQuery
7e98925 
Closes spring-projectsGH-34474

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@quaff quaff mentioned this issue Mar 20, 2025
Merged
quaff added a commit to quaff/spring-framework that referenced this issue Mar 21, 2025
@quaff
Introduce Stream variant methods for SqlQuery
2745eab 
Closes spring-projectsGH-34474

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@jhoeller
Copy link
Contributor

Superseded by PR #34623.

@jhoeller jhoeller removed this from the 7.0.x milestone Mar 21, 2025
jhoeller pushed a commit that referenced this issue Mar 21, 2025
@quaff @jhoeller
Introduce Stream variant methods for SqlQuery
8819c74 
Closes GH-34474

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce Stream variant methods for SqlQuery quaff/spring-framework
4 participants
@sbrannen @quaff @jhoeller @spring-projects-issues