Improve SimpleKey hashing function #34483
Assignees
Labels
in: core
Issues in core modules (aop, beans, core, context, expression)
type: enhancement
A general enhancement
Milestone
Comments
bclozel
added
in: core
dantewang
added a commit
to dantewang/liferay-portal
that referenced
this issue
Mar 17, 2025
slnn
pushed a commit
to slnn/liferay-portal
that referenced
this issue
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SimpleKeyis used in Spring Framework's caching support and itshashCodevalue can be used to efficiently store this key in data structures. As discussed with @ben-manes, the current hashcode strategy works, but the resulting values don't spread well enough when input keys are sequential (which is often the case). This can have negative performance impacts, depending on the data structures used by the cache implementation.We should improve the
hashCodefunction with a mixer function to better spread the hash values. While this is not a bug in Spring Framework this should improve performance for some cache implementations in production.The text was updated successfully, but these errors were encountered: