Skip to content

Migrate remaining JUnit 4 tests to JUnit Jupiter where feasible #34813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbrannen opened this issue Apr 24, 2025 · 1 comment
Closed

Migrate remaining JUnit 4 tests to JUnit Jupiter where feasible #34813

sbrannen opened this issue Apr 24, 2025 · 1 comment
Assignees
Labels
in: test Issues in the test module type: task A general task
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Apr 24, 2025

Overview

In #23451, we migrated most of the test suite from JUnit 4 to JUnit Jupiter; however, several tests in the spring-test module are still based on JUnit 4.

Since we are now planning to deprecate our JUnit 4 support in 7.0, we should stop using JUnit 4 where feasible.

In other words, the only remaining tests based on JUnit 4 should be tests that are required to run with JUnit 4 in order to test our JUnit 4 support.

Performing this migration will then make it easier to deprecate and finally remove our JUnit 4 support. Additionally, we should be able to simplify our Checkstyle rules by doing so.

This issue is targeted for 6.2.x in order to avoid forward-merge conflicts during the 7.0 development phase as much as possible.

Related Issues

@sbrannen sbrannen added in: test Issues in the test module type: task A general task labels Apr 24, 2025
@sbrannen sbrannen added this to the 6.2.7 milestone Apr 24, 2025
@sbrannen sbrannen self-assigned this Apr 24, 2025
@sbrannen
Copy link
Member Author

In 49e5c84 I unfortunately overlooked several JUnit 4 based tests in the junit4 package that should be migrated to JUnit Jupiter.

I am therefore reopening this issue to address those remaining test classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: test Issues in the test module type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant