Skip to content

Update outdated example that uses JettyHttpHandlerAdapter in the reference manual #34875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sbrannen opened this issue May 9, 2025 · 2 comments · May be fixed by #34877
Open

Update outdated example that uses JettyHttpHandlerAdapter in the reference manual #34875

sbrannen opened this issue May 9, 2025 · 2 comments · May be fixed by #34877
Labels
type: documentation A documentation task
Milestone
7.0.0-M5

Comments

@sbrannen
Copy link
Member

sbrannen commented May 9, 2025

Just a quick note that https://github.com/spring-projects/spring-framework/blob/main/framework-docs/modules/ROOT/pages/web/webflux/reactive-spring.adoc still mentions the handler

Originally posted by @philwebb in #33747
@sbrannen sbrannen self-assigned this May 9, 2025
@sbrannen sbrannen added the type: documentation A documentation task label May 9, 2025
@sbrannen sbrannen added this to the 7.0.0-M5 milestone May 9, 2025
@sbrannen sbrannen changed the title Remove references to JettyHttpHandlerAdapter Update outdated example that uses JettyHttpHandlerAdapter in the reference manual May 9, 2025
@sbrannen sbrannen removed their assignment May 9, 2025
@kssumin
Copy link

kssumin commented May 10, 2025

Hi! I'd like to work on this documentation issue.

I'll update the outdated JettyHttpHandlerAdapter example in the reference manual to reflect current best practices and ensure compatibility with Jetty 12.

My plan is to:

  1. Update the example code in the reactive-spring.adoc file
  2. Ensure compatibility with Jetty 12 API changes
  3. Maintain consistency with other server adapter examples in the documentation

I'll submit a PR with the documentation changes soon.

This was referenced May 10, 2025
Closed
Closed
kssumin pushed a commit to kssumin/spring-framework that referenced this issue May 11, 2025
Update outdated JettyHttpHandlerAdapter example in reference docs
77d9a55 
Replace deprecated JettyHttpHandlerAdapter with JettyCoreHttpHandlerAdapter
in both Java and Kotlin examples for Jetty 12 compatibility.

Closes spring-projectsgh-34875

Signed-off-by: kssumin <201566@jnu.ac.kr>
kssumin added a commit to kssumin/spring-framework that referenced this issue May 11, 2025
@kssumin
git commit -m "Update JettyHttpHandlerAdapter example to use JettyCor…
a1d1f1a 
…eHttpHandlerAdapter

- Replaced deprecated JettyHttpHandlerAdapter with JettyCoreHttpHandlerAdapter
- Updated example to work with Jetty 12+
- Added note about the deprecation

Closes spring-projectsgh-34875"

Signed-off-by: kssumin <201566@jnu.ac.kr>
kssumin added a commit to kssumin/spring-framework that referenced this issue May 11, 2025
@kssumin
Update JettyHttpHandlerAdapter example to use JettyCoreHttpHandlerAda…
6a4309e 
…pter

- Replaced deprecated JettyHttpHandlerAdapter with JettyCoreHttpHandlerAdapter
- Updated example to work with Jetty 12+
- Added note about the deprecation

Closes spring-projectsgh-34875

Signed-off-by: kssumin <201566@jnu.ac.kr>
@kssumin kssumin linked a pull request May 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation A documentation task
Projects
None yet
Milestone
7.0.0-M5
Development

Successfully merging a pull request may close this issue.

Update outdated JettyHttpHandlerAdapter example in reference documentation kssumin/spring-framework
3 participants
@sbrannen @kssumin and others