Skip to content

GZIP compression filter [SPR-787] #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spring-projects-issues opened this issue Mar 15, 2005 · 4 comments
Closed

GZIP compression filter [SPR-787] #5514

spring-projects-issues opened this issue Mar 15, 2005 · 4 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Mar 15, 2005

Matthew Sgarlata opened SPR-787 and commented

GZIP compression filters are one of the best examples of a great application of Filter technologies in the Servlet API. There are plenty of examples on the web, but they don't seem to have found a home in any open source frameworks. Since Spring's goal is to make working with J2EE APIs easier, I think Spring would be a perfect home for a GZIP compression filter. A compression filter is a conceptually simple application of GZIP APIs (streams, compression, Servlet API, etc) yet is surprisingly difficult to implement. Finding a home at Spring would create a standard implementation of this common feature for all to benefit.

One of the Tomcat 4.0 examples is a GZIP compression filter. However, the Tomcat team is not interested in clearly not interested in mainting it and making sure it's production-ready across application servers (else, why would they bundle it with their examples instead of giving them a proper package name, etc.). I propose we adapt the code for Spring.

Please let me know any way in which I can assist in bringing this to fruition.


Affects: 1.1.5

Issue Links:

4 votes, 3 watchers

@spring-projects-issues
Copy link
Collaborator Author

Rob Harrop commented

Perhaps one for Spring Modules instead of Spring core?

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

The question is: Should we provide such a ZIP filter at all?

Tomcat 5.x provides GZIP compression as part of its HTTP connector rather than as Servlet Filter. Arguably, ZIP compression should be part of the HTTP server rather than the web application itself.

Of course, a GZIP Filter within the application allows for fine-grained control over the zipping on a per-application and even per-path basis. But if this is independent of Spring and not trivial to implement, I'm not sure if this really belongs in Spring.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Daniel Campagnoli commented

There is a sourceforge project for a gzip filter that is fairly active still.
http://sourceforge.net/projects/pjl-comp-filter

@spring-projects-issues
Copy link
Collaborator Author

Rob Harrop commented

This is solved in a number of different areas by a number of different products (such as Tomcat and Resin) so we feel that this is not something that we should be handling in Spring.

Juergen

@spring-projects-issues spring-projects-issues added status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants