ANT does not call destroy-method after tests [SPR-2007]

[spring-projects-issues]

Rafał Malinowski opened SPR-2007 and commented

When using Spring with ant tests (inherited from AbstractTransactionalDataSourceSpringContextTests) destroy-methods aren't called, so system is full of garbage after that :(

When running with Tomcat everything works properly.

---

Affects: 1.2.8

Issue Links:

• @PreDestroy method in test instance not executed when run with SpringJUnit4ClassRunner [SPR-4868] #9544 @PreDestroy method in test instance not executed when run with SpringJUnit4ClassRunner
• When testing using JUnit 4 Suite, destroy-methods are called at the end of the test suite instead of per test [SPR-7377] #12035 When testing using JUnit 4 Suite, destroy-methods are called at the end of the test suite instead of per test
• Support for @DirtiesContext at the test class level [SPR-4702] #9379 Support for @DirtiesContext at the test class level

[spring-projects-issues]

Juergen Hoeller commented

This is a general problem with JUnit tests: There is no clear cleanup callback for global resources, such as the static ApplicationContext instances held by AbstractSpringContextTests (and its subclasses). We will revisit what we can do about it, but I'm afraid there isn't a lot in a standard JUnit environment...

Juergen

[spring-projects-issues]

Juergen Hoeller commented

Sam, are you aware of corresponding callbacks in JUnit and/or TestNG?

Juergen

[spring-projects-issues]

Sam Brannen commented

I am closing this issue as Won't Fix for the following reasons.

1. Spring's JUnit 3.8 base classes are deprecated as of Spring 3.0 and 3.1.
2. destroy-methods are not invoked until the corresponding application context has been shut down, which -- due to caching -- typically occurs at the end of the test suite.
   • See my comments for When testing using JUnit 4 Suite, destroy-methods are called at the end of the test suite instead of per test [SPR-7377] #12035.

See also #9379 for a discussion of @DirtiesContext which is supported since Spring 2.0, with additional class-level support as of Spring 3.0.