jee:jndi-lookup do not provide a way to define a default object [SPR-4012]

[spring-projects-issues]

Tomasz Pik opened SPR-4012 and commented

jee:jndi-lookup do not provide a way to define a default object (or at least documentation do not show how to setup such a thing, also xsd do not highlight any way to define it) so it cannot be used a as drop-in replacement for org.springframework.jndi.JndiObjectFactoryBean (there's no equivalent of setDefaultObject(Object)
please, provide such a possibility for jee:jndi-lookup

---

Issue Links:

• Add defaultObject attribute to <jee:jndi-lookup> tag [SPR-3785] #8465 Add defaultObject attribute to jee:jndi-lookup tag ("is duplicated by")

[spring-projects-issues]

Juergen Hoeller commented

Thanks for the suggestion! I've added "default-value" and "default-ref" attributes to "jee:jndi-lookup", translated to a default object (in JndiObjectFactoryBean terminology).

Juergen

[spring-projects-issues]

Urs Keller commented

Hello
I think the JndiLookupBeanDefinitionParser should override the
"isEligibleAttribute" method. Right now the default-ref is not working correctly, since it is converted to a property defaultRef, which is not a field on JndiObjectFactoryBean.

protected boolean isEligibleAttribute(String attributeName) {
return (super.isEligibleAttribute(attributeName) && !DEFAULT_REF.equals(attributeName) &&
!DEFAULT_VALUE.equals(attributeName) )
}

Cheers,
-Urs

[spring-projects-issues]

Juergen Hoeller commented

Indeed, thanks for pointing this out. I've fixed this for 2.5 final.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

This should be available in tonight's 2.5 snapshot. Feel free to give it a try...

Juergen