Monitoring Framework - Monitor names to stem from the implementing classes, rather than their interfaces [SPR-4275]

[spring-projects-issues]

Andreas Schildbach opened SPR-4275 and commented

Consider the following example. I'm applying a profiling aspect to my annotated services like this:

aop:config
<aop:advisor advice-ref="serviceInterceptor" pointcut-ref="services" />
</aop:config>

<bean id="serviceInterceptor" class="org.springframework.aop.interceptor.JamonPerformanceMonitorInterceptor">
<property name="trackAllInvocations" value="true" />
</bean>
<bean id="services" class="org.springframework.aop.support.annotation. AnnotationMatchingPointcut">
<constructor-arg value="org.springframework.stereotype.Service" />
</bean>

Problem is, the names of the Jamon Monitors (as per AbstractTraceInterceptor.createInvocationTraceName ()) stem from the names of the interfaces (or abstract classes), not from the actual implementation classes. This is particularly annoying for interface methods that are inherited from a 'common' interface: Those only get one monitor for all implementations together - there is no way to distinguish.

My proposal is to find a way (via Spring configuration) so that the monitor names always stem from the implementing classes.

---

Affects: 2.5 final

[spring-projects-issues]

Juergen Hoeller commented

Thanks for the suggestion! I've added a corresponding "logTargetClassInvocation" property to AbstractMonitoringInterceptor.

The log category for a "dynamic logger" (useDynamicLogger=true) is the target class anyway, but the invocation trace name was based on the proxy interface/class. logTargetClassInvocation=true uses the target class name for such invocation traces as well, provided that the invocation is actually delegated to the target object (i.e. the invocation doesn't affect an introduction).

Juergen

[spring-projects-issues]

Andreas Schildbach commented

Just tested the latest snapshot and the improvement works well! Thanks Juergen!