Skip to content

Avoid unnecessary String concatenations in StompHeaderAccessor #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dreis2211
Copy link
Contributor

Closes SPR-14625

@pivotal-issuemaster
Copy link

@dreis2211 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@sbrannen
Copy link
Member

As I mentioned in the corresponding JIRA issue...

FYI: on Spring 5.0, the proposed changes can be rewritten as lambda expressions as follows.

Assert.state(SimpMessageType.MESSAGE.equals(getMessageType()), () -> "Unexpected message type " + getMessage());

Assert.state(SimpMessageType.MESSAGE.equals(getMessageType()), () -> "Unexpected message type " + getMessage());

If backported to Spring 4.x, however, the use of an if-block will still be required.

@jhoeller
Copy link
Contributor

Thanks again for the pull request! Applied in a revised form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants