Skip to content

Work in Progress for SPR-8986 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Jan 6, 2012
Merged

Work in Progress for SPR-8986 #12

merged 0 commits into from
Jan 6, 2012

Conversation

dharrigan
Copy link
Contributor

Hi,

I wonder if I can get a bit of help on this one. I've merged into Jaxb2Marshaller the code to lookup JAXB2 annotated classes using package scanning. I'm just having difficultly understanding how to get appropriate tests written and to configure the spring-oxm-3.1.xsd properly.

The classes compile, but the tests fail for JAXB so far.

Thank you.

-=david=-

@dharrigan
Copy link
Contributor Author

Hi,

This new pull request is combined with a valid test for packagesToScan with annotations.

I'm not too familiar with XSD configuration, so I've left that out - but the Java code + test is there now.

-=david=-

@rstoyanchev
Copy link
Contributor

I see lots of whitespace differences. It looks like your IDE is inserting spaces whereas the source code has tabs. You might want to change that and re-submit so we can evaluate your exact changes. There is actually quite a bit of noise that makes it difficult to see what's changed and needs to be corrected either way.

You can check before committing for whitespace issues using git diff --check.

Also, please use git rebase -i to squash multiple commits that belong together. See the progit book and Dave Syer's blog post is also pretty useful.

@dharrigan
Copy link
Contributor Author

Sure, no problem.

-=david=-

@dharrigan dharrigan merged commit e208a2d into spring-projects:3.1.x Jan 6, 2012
bclozel added a commit that referenced this pull request Dec 16, 2015
Conditionalize reference doc/api doc links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants