SPR-15708 - Add debug logging for CORS rejections #1466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: SPR-15708
snicoll
changed the title
sdeleuze
requested changes
Jun 30, 2017
| @@ -126,7 +126,23 @@ protected boolean handleInternal(ServerHttpRequest request, ServerHttpResponse r | |||
| List<String> requestHeaders = getHeadersToUse(request, preFlightRequest); | |||
| List<String> allowHeaders = checkHeaders(config, requestHeaders); | |||
|
|
|||
| if (allowOrigin == null || allowMethods == null || (preFlightRequest && allowHeaders == null)) { | |||
| if (allowOrigin == null) { | |||
There was a problem hiding this comment.
To be moved just bellow checkOrigin invocation ?
| return false; | ||
| } | ||
|
|
||
| if (allowMethods == null) { |
There was a problem hiding this comment.
To be moved just bellow checkMethods invocation ?
| return false; | ||
| } | ||
|
|
||
| if ((preFlightRequest && allowHeaders == null)) { |
There was a problem hiding this comment.
To be moved just bellow checkHeaders invocation ?
| @@ -126,7 +126,23 @@ protected boolean handleInternal(ServerHttpRequest request, ServerHttpResponse r | |||
| List<String> requestHeaders = getHeadersToUse(request, preFlightRequest); | |||
| List<String> allowHeaders = checkHeaders(config, requestHeaders); | |||
|
|
|||
| if (allowOrigin == null || allowMethods == null || (preFlightRequest && allowHeaders == null)) { | |||
| if (allowOrigin == null) { | |||
| logger.debug("rejecting request because CORS processor cannot determine " + | |||
There was a problem hiding this comment.
What about a message like "Rejecting CORS request because '" + requestOrigin + "' origin is not allowed"
| } | ||
|
|
||
| if (allowMethods == null) { | ||
| logger.debug("rejecting request because CORS processor cannot determine " + |
There was a problem hiding this comment.
Similar remark than for origin for the message
| } | ||
|
|
||
| if ((preFlightRequest && allowHeaders == null)) { | ||
| logger.debug("rejecting request because CORS processor cannot determine " + |
There was a problem hiding this comment.
Similar remark than for origin for the message
There was a problem hiding this comment.
I'm not going to get to this any time soon - feel free to reject or do own fix.
|
Fixed via 9901c38. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: SPR-15708
I have submitted the ICLA.