SPR-15708 - Add debug logging for CORS rejections #1466
Conversation
Issue: SPR-15708
snicoll
changed the title
sdeleuze
left a comment
sdeleuze
left a comment
There was a problem hiding this comment.
Thanks, could you have a look to my remarks and force push an updated commit.
| List<String> allowHeaders = checkHeaders(config, requestHeaders); | ||
|
|
||
| if (allowOrigin == null || allowMethods == null || (preFlightRequest && allowHeaders == null)) { | ||
| if (allowOrigin == null) { |
There was a problem hiding this comment.
To be moved just bellow checkOrigin invocation ?
| return false; | ||
| } | ||
|
|
||
| if (allowMethods == null) { |
There was a problem hiding this comment.
To be moved just bellow checkMethods invocation ?
| return false; | ||
| } | ||
|
|
||
| if ((preFlightRequest && allowHeaders == null)) { |
There was a problem hiding this comment.
To be moved just bellow checkHeaders invocation ?
|
|
||
| if (allowOrigin == null || allowMethods == null || (preFlightRequest && allowHeaders == null)) { | ||
| if (allowOrigin == null) { | ||
| logger.debug("rejecting request because CORS processor cannot determine " + |
There was a problem hiding this comment.
What about a message like "Rejecting CORS request because '" + requestOrigin + "' origin is not allowed"
| } | ||
|
|
||
| if (allowMethods == null) { | ||
| logger.debug("rejecting request because CORS processor cannot determine " + |
There was a problem hiding this comment.
Similar remark than for origin for the message
| } | ||
|
|
||
| if ((preFlightRequest && allowHeaders == null)) { | ||
| logger.debug("rejecting request because CORS processor cannot determine " + |
There was a problem hiding this comment.
Similar remark than for origin for the message
There was a problem hiding this comment.
I'm not going to get to this any time soon - feel free to reject or do own fix.
|
Fixed via 9901c38. |
2 participants
Issue: SPR-15708
I have submitted the ICLA.