Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set thread interrupt flag on InterruptedException #1668

Closed
wants to merge 1 commit into from
Closed

Set thread interrupt flag on InterruptedException #1668

wants to merge 1 commit into from

Conversation

igor-suhorukov
Copy link
Contributor

No description provided.

@jhoeller
Copy link
Contributor

jhoeller commented Feb 8, 2018

Indeed, looks like we're missing a few interrupt() calls there which is also inconsistent with other places in the framework codebase. Could you please create a JIRA issue for this? I'll merge this into 5.0.4 and 4.3.15 then.

@igor-suhorukov
Copy link
Contributor Author

@jhoeller thank you for assistance. I create ticket SPR-16479 as you wish

@jhoeller
Copy link
Contributor

jhoeller commented Feb 9, 2018

@igor-suhorukov, could you please refer to SPR-16479 in your commit (we usually add a line "Issue: SPR-16479") at the end of the commit message) and switch to upper-case "Set..." at the beginning while you're at it? This would allow for a direct merge to master, making it easier to backport to the 4.3.x branch.

@igor-suhorukov
Copy link
Contributor Author

igor-suhorukov commented Feb 9, 2018

@jhoeller sorry I deleted this fork from my repo.
I can create another PR with required comment if it really needed

@jhoeller
Copy link
Contributor

No worries, I've gone through those six places manually and also made the exception wrapping consistent. Thanks for the pull request, in any case! And of course, also for your others - all well spotted and very welcome. I'll selectively backport some of those refinements to 4.3.x as well but since they don't constitute a behavioral bug we don't really need a JIRA ticket for those others (just for this one here).

@jhoeller jhoeller closed this Feb 10, 2018
@igor-suhorukov
Copy link
Contributor Author

Thank you @jhoeller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants