Skip to content

Update TransactionTemplate#equals() and #hashCode() #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

arne-vandamme
Copy link

Inspect the PlatformTransactionManager property as well.
Issues: SPR-16572

Inspect the PlatformTransactionManager property as well.
Issues: SPR-16572
@pivotal-issuemaster
Copy link

@arne-vandamme Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@arne-vandamme Thank you for signing the Contributor License Agreement!

@jhoeller
Copy link
Contributor

jhoeller commented Mar 9, 2018

I've implemented this slightly differently, with transaction manager equality just getting enforced for an actual TransactionTemplate to compare with and not affecting toString either; in fact, not even hashCode has to be overridden for common hashing scenarios (as long as it provides the same hash code for equal templates). Not least of it all for backwards compatibility reasons, this shouldn't sacrifice the use of template instances as plain transaction definitions. Thanks for the pull request, in any case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants