SPR-16819 - Improve handling of unknown status codes by WebClient #1829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: SPR-16819
Prior to this commit, `WebClient.RequestHeadersSpec.retrieve()` always throw `IllegalArgumentException` on unknown status codes. This commit improves support of unkwnown status codes and introduces new method - `onStatusCode`, which allows to apply response error handling for status codes that can't be resolved through `HttpStatus`. New class `StatusCodePredicates` provides convenient way to create predicates for `onStatusCode` method. Issue: SPR-16819
|
Merged with 038af9a, see comment on the SPR issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are aimed to improve handling of unknown status codes by reactive
WebClient.In
ClientResponsethegetRawStatusCode()method was introduced that allows to obtain raw status code value from response after the corresponding method in reactiveClientHttpResponsewas provided (see SPR-16748).Also the
retrieve()method in defaultWebClientimplementation andstatusError()inExchangeFilterFunctionswere changed in order to provide support of unknown status codes. The newonStatusCode()(WebClient.ResponseSpec) andstatusCodeError()(ExchangeFilterFunctions) methods allow to specify exception function which should be applied on matching the status code (intvalue) against the specified predicate. TheStatusCodePredicatesprovides convenient way to create predicates for these methods.https://jira.spring.io/browse/SPR-16819