SPR-17540 JavaMailSenderImpl does not show proper message when recipient list is empty #2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent list is empty
|
@Jebil Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Jebil Thank you for signing the Contributor License Agreement! |
vrnsky
suggested changes
Dec 2, 2018
spring-context-support/src/main/java/org/springframework/mail/javamail/JavaMailSenderImpl.java
Outdated
Show resolved
Hide resolved
added 3 commits
December 3, 2018 11:51
This reverts commit fe74c7e.
vrnsky
approved these changes
Dec 3, 2018
|
As mentioned on JIRA, I've resolved this slightly differently. Thanks for the pull request, in any case! |
|
Ok @jhoeller , would you be kind enough to let me know, what I could have done better ? |
|
@Jebil there is a comment in the issue and the commit shows concretely the strategy that we preferred. Thank you very much for your contribution, in any case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.spring.io/browse/SPR-17540